From e6b2b342d2ee06bdac05d829a96dc942a2534ebc Mon Sep 17 00:00:00 2001 From: Brendan Lawlor Date: Wed, 31 Jul 2024 13:46:22 +0000 Subject: [PATCH] Bug 37536: Update conditional to check for 'cud-saveitem' In additem.pl and additem.tt all instances of 'saveitem' have been updated to 'cud-saveitem' The javascript needs to be updated in the same way. Test plan: - Make sure acqcreateitem is set to "when placing an order" - Create a basket with some orders - Close the basket - Go to your vendor and receive an order - On the receive page, try to edit your item => Without the patch, the pop up page will open and then close, not allowing the item to be edited. => With this patch applied you will see the item edit form. Save and confirm that the parent window is updated with the new value (actually it's refreshed) QA notes: 1. git grep 'saveitem' 2. Notice all instances in additem.pl and additem.tt have been updated to 'cud-saveitem' 3. Notice cataloging_additem.js checks if op != 'saveitem' 4. Check the files and verify the change makes sense Signed-off-by: Victor Grousset/tuxayo Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js index 06fc9137e5..c8a2189b83 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging_additem.js @@ -9,7 +9,7 @@ $(document).ready(function(){ // otherwise the deletion confirmation will not work correctly $('a[href*="biblionumber="]').off('click'); - if( popup && op != 'saveitem' ){ + if( popup && op != 'cud-saveitem' ){ window.close(); } -- 2.39.5