From f042890e5f66f52bba8159990acc7eaea4d3bfd8 Mon Sep 17 00:00:00 2001
From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Date: Fri, 10 Nov 2023 11:00:55 +0000
Subject: [PATCH] Bug 35310: Only show 'Current renewals' <li> entry if there
 are current renewals

'Current renewals' is always showing, even if empty.

Test plan:
1) Checkout an item to Koha user, barcode 39999000003192
2) Renew that barcode
3) Visit the items page of the biblio record, click on "View" in front of "Current renewals"
/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76
4) Notice all items have the 'Current renewals' label entry, but only the checked out item in step 1) has the 'Current renewals' label entry
5) Apply patch. Notice only the item with current renewals is showing the 'Current renewals' label entry with the respective value.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 942c4a0535dbbf46746e849758d7dfc741187bec)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 9eacb4b40f1c35d2e713ef04ca376ace44408eef)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
---
 .../prog/en/modules/catalogue/moredetail.tt        | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
index fc7658d948..03374f2208 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt
@@ -180,13 +180,13 @@
                                                 [% END %]
                                             [% END %]
                                         </li>
-                                        <li>
-                                            <span class="label">Current renewals:</span>
-                                            [% ITEM_DAT.renewals | html %]
-                                            [% IF ITEM_DAT.renewals %]
-                                                [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.renewals | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ]
-                                            [% END %]
-                                        </li>
+                                        [% IF ITEM_DAT.renewals %]
+                                            <li>
+                                                <span class="label">Current renewals:</span>
+                                                [% ITEM_DAT.renewals | html %]
+                                                    [ <a class="checkout_renewals_view" data-renewals="[% ITEM_DAT.renewals | html | html %]" data-issueid="[% ITEM_DAT.object.checkout.id | html %]" href="#">View</a> ]
+                                            </li>
+                                        [% END %]
                                         [% IF itemlostloop %]
                                             <li>
                                                 <span class="label">Lost status:</span>
-- 
2.39.5