From d800011525f8b4a4d68c6e016fb7fa2e78ff9933 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 19 Aug 2021 10:49:34 -0400 Subject: [PATCH] Bug 28885: Skip invalid biblios for OpacBrowseResults MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If a record is deleted from Koha, but is for some reason not deleted from the search indexes, OpacBrowseResults can cause an ISE if the deleted record is in the search results for any given item. OpacBrowseResults loops through the search results, and checks if there is a biblionumber, but does *not* check to see if a result was pulled from the database for that biblionumber. It simply assumes the result must exist. We should be checking to ensure the biblionumber was valid before operating on the biblio object. Test Plan: 1) Use zebra for searching 2) Disable koha-indexer 3) Enable OpacBrowseResults 4) Perform a search 5) Delete an item in the search results 6) View on of the remaining items in the search results 7) Note the error 8) Apply this patch 9) Restart plack 10) Reload the page 11) The error should be gone! Signed-off-by: David Nind Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit a478eb1b4f52d3fb1fa2e8526511e5eb11df1619) Signed-off-by: Fridolin Somers (cherry picked from commit b6c9ab1197f8f140ac1dbda46b7d520fe4fd6c80) Signed-off-by: Victor Grousset/tuxayo --- opac/opac-detail.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl index b6a5b0b1ff..43255e6689 100755 --- a/opac/opac-detail.pl +++ b/opac/opac-detail.pl @@ -497,6 +497,7 @@ if ($session->param('busc')) { for (my $j = 0; $j < @arrBiblios; $j++) { next unless ($arrBiblios[$j]); $dataBiblioPaging = Koha::Biblios->find( $arrBiblios[$j] ) if ($arrBiblios[$j] != $biblionumber); + next unless $dataBiblioPaging; push @listResults, {index => $j + 1 + $offset, biblionumber => $arrBiblios[$j], title => ($arrBiblios[$j] == $biblionumber)?'':$dataBiblioPaging->title, author => ($arrBiblios[$j] != $biblionumber && $dataBiblioPaging->author)?$dataBiblioPaging->author:'', url => ($arrBiblios[$j] == $biblionumber)?'':'opac-detail.pl?biblionumber=' . $arrBiblios[$j]}; } $template->param('listResults' => \@listResults) if (@listResults); -- 2.39.5