]> git.koha-community.org Git - koha.git/commit
Bug 25118: Return claims has some translation issues
authorOwen Leonard <oleonard@myacpl.org>
Tue, 14 Apr 2020 11:52:17 +0000 (11:52 +0000)
committerJoy Nelson <joy@bywatersolutions.com>
Fri, 8 May 2020 20:36:18 +0000 (20:36 +0000)
commitbfa97dc73ca24f41dcabef058e7e50c42f29e0ef
tree1bfcd1a2e4793070c95b2ff2d5712b5f0dfc2cd1
parent0d5d14935aa6749ff02ac885e3b3697a3a08f29f
Bug 25118: Return claims has some translation issues

This patch adds the right function calls to checkouts.js so that English
strings can be picked up by the translator. The resolution message has
been reformatted so that it can be clear without including "on" and
"by" in the middle of the string.

To test you should have a patron with at least one return claim. Open
the checkout page for that patron and open the "Claims" tab. Test the
process of editing, deleting, and resolving claims.

TESTING TRANSLATABILITY

- Update a translation:

> cd misc/translator
> perl translate update fr-FR

- Open the corresponding .po file for the staff
  client: misc/translator/po/fr-FR-messages-js.po
- Locate strings pulled from checkouts.js for translation, e.g.:

  #: koha-tmpl/intranet-tmpl/prog/js/checkouts.js:920
  msgid "Double click to edit"
  msgstr ""

- Edit the "msgstr" string however you want (it's just for testing).
- Install the updated translation:

> perl translate install fr-FR

Switch to the udpated translation and test the functionality under the
"Claims" tab again to confirm that your translated strings appear.

Note that "untranslatable string" failures reported by the QA script are
false positives.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/js/checkouts.js