]> git.koha-community.org Git - koha.git/commit
Bug 31540: Exclude expired holds from the reminder job
authorNick Clemens <nick@bywatersolutions.com>
Mon, 12 Sep 2022 14:35:24 +0000 (14:35 +0000)
committerWainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
Thu, 15 Dec 2022 11:29:12 +0000 (11:29 +0000)
commit154af0fae71fd694010653703bea41b0abbc4aec
tree9fb4d11d0309dd70c41cdfcf95d42bd7322930af
parent48f09bbc6baf58e28cf292f8312c1d6fa5ae07f5
Bug 31540: Exclude expired holds from the reminder job

Some libraries don't want to auto-cancel holds, but we should not remind
a patron about a hold which has expired.

To test:
1 - Place a hold for a patron
2 - Set it waiting
3 - Run the holds reminder script in the future
    perl misc/cronjobs/holds/holds_reminder.pl -day 1 --date '2023-09-12' -v
4 - Note the holds would be reminded
5 - Set expirationdate for the hold less than today
    UPDATE reserves SET expirationdate = DATE_SUB(CURDATE(), INTERVAL 1 DAY);
6 - Run the remidner cron again
7 - No holds trigger!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4c3d18091d821af2d9ac7a6178547cc9c478f9de)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 6e3ff69730ec269973cc5225a99e5ce7123f05f7)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
(cherry picked from commit fce44867acdcfe34bea0cf165601d51081c85c5c)
Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz>
(cherry picked from commit fce44867acdcfe34bea0cf165601d51081c85c5c)
misc/cronjobs/holds/holds_reminder.pl