From 2e64c48f3d85b09e7f952a3fb9975c80b0b7f61f Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 10 Feb 2023 23:28:40 +0100 Subject: [PATCH] Bug 32492: Add IDs to the rows of the patron messaging table in OPAC and staff interface Sometimes you want to hide notice from the messaging options becaue the library is not using it. With this patch, we'll have unique IDs on the to do so easily. To test: * Look at the messaging preferences * in the OPAC messaging tab * in the staff interface details tab * in the staff interface patron edit form * Verify there are no classes or IDs on the rows or other elements * Apply patch * Verify there are nice IDs now on the table rows (tr elements) for each message. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 7371ee848ffd12ea92bb5e7c33916b15cb8e54fd) Signed-off-by: Matt Blenkinsop (cherry picked from commit 05163003b22192a29f735de3163edba8c2a6d8a2) Signed-off-by: Lucas Gass (cherry picked from commit 0b63fb2a93ea9e0757f5846f8758a5777975d8fa) Signed-off-by: Arthur Suzuki --- .../prog/en/includes/messaging-preference-form.inc | 12 ++++++------ .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 12 ++++++------ 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc index adb9cdc97d..5ca4c60352 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc @@ -19,12 +19,12 @@ [% FOREACH messaging_preference IN messaging_preferences %] [% NEXT IF !Koha.Preference( 'ILLModule' ) && messaging_preference.message_name.match('^Ill_') %] [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %] - - [% IF ( messaging_preference.Item_Due ) %]Item due - [% ELSIF ( messaging_preference.Advance_Notice ) %]Advance notice - [% ELSIF ( messaging_preference.Hold_Filled ) %]Hold filled - [% ELSIF ( messaging_preference.Hold_Reminder ) %]Hold reminder - [% ELSIF ( messaging_preference.Item_Check_in ) %]Item check-in + + [% IF ( messaging_preference.Item_Due ) %]Item due + [% ELSIF ( messaging_preference.Advance_Notice ) %]Advance notice + [% ELSIF ( messaging_preference.Hold_Filled ) %]Hold filled + [% ELSIF ( messaging_preference.Hold_Reminder ) %]Hold reminder + [% ELSIF ( messaging_preference.Item_Check_in ) %]Item check-in [% ELSIF ( messaging_preference.Item_Checkout ) %] [% IF Koha.Preference( 'RenewalSendNotice' ) %] Item checkout and renewal diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt index 2b7221bb99..40ad9ae5c2 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt @@ -61,12 +61,12 @@ [% FOREACH messaging_preference IN messaging_preferences %] [% NEXT IF !Koha.Preference( 'ILLModule' ) && messaging_preference.message_name.match('^Ill_') %] [% NEXT IF messaging_preference.Auto_Renewals && Koha.Preference('AutoRenewalNotices') != 'preferences' %] - - [% IF ( messaging_preference.Item_Due ) %]Item due - [% ELSIF ( messaging_preference.Advance_Notice ) %]Advance notice - [% ELSIF ( messaging_preference.Hold_Filled ) %]Hold filled - [% ELSIF ( messaging_preference.Hold_Reminder ) %]Hold reminder - [% ELSIF ( messaging_preference.Item_Check_in ) %]Item check-in + + [% IF ( messaging_preference.Item_Due ) %]Item due + [% ELSIF ( messaging_preference.Advance_Notice ) %]Advance notice + [% ELSIF ( messaging_preference.Hold_Filled ) %]Hold filled + [% ELSIF ( messaging_preference.Hold_Reminder ) %]Hold reminder + [% ELSIF ( messaging_preference.Item_Check_in ) %]Item check-in [% ELSIF ( messaging_preference.Item_Checkout ) %] [% IF Koha.Preference( 'RenewalSendNotice' ) %] Item checkout and renewal -- 2.39.5