From fd51df2ccfc3a52676dd1a1922cbd05fc546a61e Mon Sep 17 00:00:00 2001 From: Thomas Misilo Date: Wed, 16 Sep 2015 13:43:28 -0400 Subject: [PATCH] Bug 14244: viewing a bib item's circ history requires circulation permissions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit On issuehistory.pl you have: flagsrequired => { circulate => "circulate_remaining_permissions" }, But that really doesn't make sense. People should be able to view the history of circulation without having permission to circulate items themselves This patch changes the required permissions from circulate to catalogue. Test Plan: 1. Login as user without the circulate_remaining_permissions 2. Attempt to view Circulation History of an Item 3. Does not work 4. Apply Patch 5. Attempt to view circulation history with a user that has access to the staff side. 6. Can view circulation history now Signed-off-by: Nicole Engard Signed-off-by: Jonathan Druart Signed-off-by: Marc Véron Signed-off-by: Kyle M Hall Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com (cherry picked from commit e8c5fb11fbebc86742325aea745bc7253d9110d8) Signed-off-by: Julian Maurice (cherry picked from commit a835060b9c10272fccf5262f5c77cc9d0031de7f) Signed-off-by: Frédéric Demians --- catalogue/issuehistory.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/catalogue/issuehistory.pl b/catalogue/issuehistory.pl index fae5038a6b..b10614355f 100755 --- a/catalogue/issuehistory.pl +++ b/catalogue/issuehistory.pl @@ -34,7 +34,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( query => $query, type => "intranet", authnotrequired => 0, - flagsrequired => { circulate => "circulate_remaining_permissions" }, + flagsrequired => { catalogue => 1 }, } ); -- 2.39.5