]> git.koha-community.org Git - koha.git/commit
Bug 12873 - Reserve can be cancelled by any logged in user
authorRafal Kopaczka <rkk0@poczta.onet.pl>
Thu, 4 Sep 2014 14:40:33 +0000 (16:40 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 2 Oct 2014 07:16:24 +0000 (09:16 +0200)
commit214e87d886faaf7abf64c1dc83d3b590d6adc8dc
tree7fffff7dacd8accfdef55451206e76ad278dbdb1
parent79b0191649809ac198bc1f0a57e7db1a68e4df39
Bug 12873 - Reserve can be cancelled by any logged in user

It is possible to cancel reservations through simply running opac-modreserve.pl with existing reserve_id number. This may provide remove even all reservations from system. The only limitation is that user have to be logged in. Simplest solution is to check whether reserve belongs to user or not.

Test plan:
1. Create reserves by 2 different users, and get their ID's
2. Before patch, hold may by cancelled by anyone who run site:
http://example.com/cgi-bin/koha/opac-modrequest.pl?reserve_id=XXX
3. After patch hold may by cancelled only by user whose reserve is.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 60875757c761a9ad59734e968cf34a831c65e9a6)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
opac/opac-modrequest.pl