]> git.koha-community.org Git - koha.git/commit
Bug 18996: [QA Follow-up] Remove global variables from Message.t
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 2 Aug 2017 11:01:47 +0000 (13:01 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 6 Sep 2017 12:11:44 +0000 (14:11 +0200)
commit50e257e217a66fa61edca5ee481c16c980838fd8
treed3bbef74a4e630cb0ab6e8d734453d84624edda6
parentbba3b49c0960de7aa928c20209eaf5441f47da22
Bug 18996: [QA Follow-up] Remove global variables from Message.t

As per request of Colin in comment18, this patch makes the use of global
variables in Message.t no longer needed.
The three subtests are now completely independent and could well be moved
to separate test scripts.

Note: Strictly speaking, the use of global (package) variables could
potentially introduce new bugs (e.g. if the value is modified outside the
script). This seems not to be the case here, but we are safe now.

Test plan:
Run the test again.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 37d07b28ce4089f691631bde3f6e9a2fe7b81b10)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/db_dependent/SIP/Message.t