]> git.koha-community.org Git - koha.git/commit
Bug 17246: Do no support arrayref to define multiple FK
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 5 Sep 2016 08:54:35 +0000 (09:54 +0100)
committerKatrin Fischer <katrin.fischer.83@web.de>
Tue, 3 Jan 2017 23:39:19 +0000 (23:39 +0000)
commit680b807653de19255b4df2c9ca3f4170a0217422
tree711b19b036ea92d3b3c1a19a0269cfec35d2ccdb
parent3bfafe1802eea486bf72a1d1fd7374a6750245ee
Bug 17246: Do no support arrayref to define multiple FK

Currently you can call GetPreparedLetter like:

$prepared_letter = GetPreparedLetter(
    (
        module      => 'test',
        letter_code => 'TEST_HOLD',
        tables      => {
            reserves => [ $fk1, $fk2 ],
        },
    )
);

It assumes that $fk1 is a borrowernumber and $fk2 a biblionumber.
It seems hazardous to do this guess.

I suggest to remove this feature and only allow hashref indeed.

Test plan:
Use different way to generate letters and make sure you do not reach the croak

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit ea7bd9c4ada6eb6f03d37e43cce89d1431293761)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
C4/Letters.pm
t/db_dependent/Letters/TemplateToolkit.t