]> git.koha-community.org Git - koha.git/commit
Bug 7943: Authority search results are untranslatable
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Wed, 30 May 2012 19:20:40 +0000 (15:20 -0400)
committerChris Cormack <chrisc@catalyst.net.nz>
Thu, 26 Jul 2012 20:23:16 +0000 (08:23 +1200)
commite666a29698c29557ae3d3d2a074de0e2dc3e66ae
treeb0928b81b8cb163eb6e1e017c65b950665223391
parent71900d9d1088651690013a4413301b0476b5bab9
Bug 7943: Authority search results are untranslatable

The HTML for authority search results was previously generated in
C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be
translated. This patch moves the HTML generation into the templates
by introducing a new authorities-search-results.inc include file for
both the OPAC and the Intranet which contains a Template::Toolkit BLOCK
for rendering the authority results. Fixes the authority autocomplete
by removing the untranslatable strings, and returning only data from
the database.

To test:
1. Apply patch.
2. Test authority searching in the authority module in the staff client
3. Test authority searching in the authority control plugin in the
   cataloguing module (and the plugin for UNIMARC field 210$c, if you
   can figure out how)
4. Test authority searching in the OPAC

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with MARC21 data.

1) Applies cleanly on current HEAD.

2) Authority search in staff

Patch works wonderfully, only some small notes found while testing that have
not been changed by this patch:

ENH note: Search terms show up nowhere. So if I want to change the sorting, I have to
repeat typing in my search term. Even if the form does not keep the term, it
should be visible somewhere on the screen what I searched for.

ENH note: The pagination on top and at the bottom of the result list are formatted
differently. Maybe some missing CSS?

ENH note: Also the authority type is not shown at all in the result list.

3) Cataloguing and authority plugins

The autocomplete function works nicely.

ENH note: There is only one small enhancement
I could imagine. If I start my search from 100 it will limit the search to
'persons' but the autocomplete will also suggest other authorities. It would
be a bit cleaner, if the autocomplete could limit by the appropriate authority
type too. Very nice feature.

Plugins overall work nicely. Created links include the authority numbers and work
correctly.

4) Authority search in OPAC

Works nicely. Display is consistent, but translatability greatly improved.

ENH note: In staff we use 'Details' in OPAC we use 'View full heading' - I wonder
if maybe 'details' would be better understandable for users?

Note: Code reveals a system preference 'AuthDisplayHierarchy' that is
not available in the system preference editor. I talked to Jared and he
will work on this feature later on. For now it's no regression, as the
preference has never been visible.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased for 3.8.x on 21 June 2012.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
15 files changed:
C4/Auth.pm
C4/AuthoritiesMarc.pm
authorities/ysearch.pl
cataloguing/addbiblio.pl
koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc [new file with mode: 0644]
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_210c.tt
koha-tmpl/opac-tmpl/prog/en/css/opac.css
koha-tmpl/opac-tmpl/prog/en/includes/authorities-search-results.inc [new file with mode: 0644]
koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt [new file with mode: 0644]
koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiesdetail.tt [deleted file]
koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiessearchresultlist.tt
opac/opac-authoritiesdetail.pl