From 7fbdda3e04fb675394746f9afbf680be34d641c7 Mon Sep 17 00:00:00 2001 From: Sophie Meynieux Date: Fri, 14 Feb 2014 12:10:32 +0100 Subject: [PATCH] Bug 11760: In notices, output road type description rather than code Test plan : - Define a notice containing <> - Trigger an event that generate this notice Without patch <> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer This works as described, passes tests and QA script. Note: it seems it's not possible currently to use B_streettype from the interface, but it might be worth adding it as a follow up for later use. Signed-off-by: Galen Charlton (cherry picked from commit b5d85741a7d297c70783a649ac00f26c82351a6f) Signed-off-by: Fridolin Somers --- C4/Letters.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/C4/Letters.pm b/C4/Letters.pm index 99f9a88ccc..2c4ff83f6e 100644 --- a/C4/Letters.pm +++ b/C4/Letters.pm @@ -23,6 +23,7 @@ use warnings; use MIME::Lite; use Mail::Sendmail; +use C4::Koha qw(GetAuthorisedValueByCode); use C4::Members; use C4::Members::Attributes qw(GetBorrowerAttributes); use C4::Branch; @@ -637,6 +638,7 @@ sub _parseletter { #Therefore adding the test on biblio. This includes biblioitems, #but excludes items. Removed unneeded global and lookahead. + $val = GetAuthorisedValueByCode ('ROADTYPE', $val, 0) if $table=~/^borrowers$/ && $field=~/^streettype$/; my $replacedby = defined ($val) ? $val : ''; ($letter->{title} ) and do { $letter->{title} =~ s/$replacetablefield/$replacedby/g; -- 2.39.5