]> git.koha-community.org Git - koha.git/commit
Bug 30694: Set decreaseloanholds undef when deleting circulation rule
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Tue, 15 Nov 2022 07:31:13 +0000 (09:31 +0200)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Thu, 26 Jan 2023 10:49:50 +0000 (11:49 +0100)
commit2570fe4f67e73443178561e27635d621df2eed4d
treee1fbf4c79aa21cf171e8784f08421f0e45af3124
parent424caa64be117e4607f942efc720bbf451a02c57
Bug 30694: Set decreaseloanholds undef when deleting circulation rule

When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds" filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 91fc31c32ba14817d989bcd34854ebc8e41fa936)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
(cherry picked from commit 63fd9be98befc0be358b0074b94253befa929f48)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 4bc18581f81aaa7872fd785f215acf2b4a4ce280)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
admin/smart-rules.pl