From 2b54c118c4851b222a96a1531607b94a144be7f7 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 24 Sep 2024 13:49:17 +0000
Subject: [PATCH] Bug 37988: Use Bootstrap 5 class .visually-hidden-focusable

It looks to me like we can remove the visibility properties from the
home button CSS and wrap the text in a <span> with Bootstrap 5's
"visually-hidden-focusable" class:

https://getbootstrap.com/docs/5.3/getting-started/accessibility/#visually-hidden-content

That appears to give us the behavior we want: A focusable icon which
isn't obscured by the focus border.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).

In the staff interface, test some pages by using tab or shift-tab to
move between elements on the page to confirm that the home icon can be
tabbed to.

Signed-off-by: Olivier Vezina <olivier.vezina@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss    | 4 ----
 koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
index 611fc240aa..40deeaf44d 100644
--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
@@ -2979,9 +2979,6 @@ nav {
     a {
         &[href="/cgi-bin/koha/mainpage.pl"] {
             color: $green-text-color;
-            font-size: 1px;
-            letter-spacing: -1px;
-            visibility: hidden;
 
             &::before {
                 content: "\f015";
@@ -2989,7 +2986,6 @@ nav {
                 font-size: 12px;
                 font-style: normal;
                 padding-right: .3em;
-                visibility: visible;
             }
 
             &:hover {
diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
index 4ff81a0a70..12eba7fa6d 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc
@@ -465,7 +465,7 @@
         <ol class="breadcrumb">
             [%# Include the Home link every time %]
             [% WRAPPER breadcrumb_item %]
-                <a href="/cgi-bin/koha/mainpage.pl" title="Home">Home</a>
+                <a href="/cgi-bin/koha/mainpage.pl" title="Home"><span class="visually-hidden-focusable">Home</span></a>
             [% END %]
             [% content | $raw %]
         </ol>
-- 
2.39.5