From c3cf9a1ef9370df59aedb4a441bbab2644f214d3 Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Thu, 18 Feb 2021 07:47:11 +0000 Subject: [PATCH] Bug 27131: (QA follow-up) POD and comments Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- Koha/Holds.pm | 6 ++++++ t/db_dependent/Koha/Holds.t | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Koha/Holds.pm b/Koha/Holds.pm index 4a25babff5..a1d6288348 100644 --- a/Koha/Holds.pm +++ b/Koha/Holds.pm @@ -92,6 +92,12 @@ sub forced_hold_level { return; } +=head3 get_items_that_can_fill + +Developer will certainly submit an appropriate description. + +=cut + sub get_items_that_can_fill { my ( $self ) = @_; diff --git a/t/db_dependent/Koha/Holds.t b/t/db_dependent/Koha/Holds.t index 8084791fac..0bce39dc52 100755 --- a/t/db_dependent/Koha/Holds.t +++ b/t/db_dependent/Koha/Holds.t @@ -414,6 +414,7 @@ subtest 'get_items_that_can_fill' => sub { my $biblio = $builder->build_sample_biblio; my $item_1 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } ); + # waiting my $item_2 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } ); my $item_3 = $builder->build_sample_item( { biblionumber => $biblio->biblionumber } ) ; # onloan @@ -481,7 +482,7 @@ subtest 'get_items_that_can_fill' => sub { my @items = $holds->get_items_that_can_fill; is_deeply( [ map { $_->itemnumber } @items ], - [ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 1 and 5 are available for filling the hold' ); + [ $item_2->itemnumber, $item_5->itemnumber ], 'Only item 2 and 5 are available for filling the hold' ); }; $schema->storage->txn_rollback; -- 2.39.5