From b044fb0ebef6bff496006257b5e9a96092d7ba53 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 13 Oct 2021 10:16:00 +0200
Subject: [PATCH] Bug 29218: Rename .hidden class for DT visibility

.hidden get the CSS that interferes with DT behaviour

.hidden {
    display: none !important;
}

Test this patch with bug 28859.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/includes/columns_settings.inc    | 1 +
 .../prog/en/modules/reports/guided_reports_start.tt        | 7 ++-----
 .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt    | 7 ++-----
 3 files changed, 5 insertions(+), 10 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
index 0fd092013e..4d66a85d51 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
@@ -134,6 +134,7 @@ function KohaTable(id_selector, dt_parameters, columns_settings, add_filters) {
         { "targets": [ "string-sort" ],  "type": "string" },
         { "targets": [ "anti-the" ],     "type": "anti-the" },
         { "targets": [ "NoSort" ],       "orderable": false, "searchable": false },
+        { "targets": [ "NoVisible" ],    "visible": false }
     ];
     if ( new_parameters["aoColumnDefs"] === undefined ) {
         new_parameters["aoColumnDefs"] = default_column_defs;
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index 077ed24f4b..0cde4b3843 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -275,13 +275,13 @@
                                                 [% IF (usecache) %]
                                                     <th>Cache expiry (seconds)</th>
                                                 [% ELSE %]
-                                                    <th class="hidden">&nbsp;</th>
+                                                    <th class="NoVisible">Cache expiry (seconds)</th>
                                                 [% END %]
                                                 <th>Saved results</th>
                                                 [% IF has_obsolete_reports %]
                                                     <th>Update</th>
                                                 [% ELSE %]
-                                                    <th class="hidden">&nbsp;</th>
+                                                    <th class="NoVisible">Update</th>
                                                 [% END %]
                                                 <th class="NoSort noExport">Actions</th>
                                             </tr>
@@ -1717,9 +1717,6 @@
                     'bAutoWidth': false,
                     'sPaginationType': 'full',
                     'aaSorting': [[ 1, "asc" ]],
-                    'aoColumnDefs': [
-                        { "visible": false, "aTargets" : [ "hidden" ] }
-                    ],
                     'oLanguage': {
                         'sZeroRecords': _("No matching reports found")
                     },
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
index 39fbc7c12e..040a9c0c32 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
@@ -145,7 +145,7 @@
                                                 [% IF ( op == 'show' ) %]
                                                     <th class="NoSort">&nbsp;</th>
                                                 [% ELSE %]
-                                                    <th class="hidden">&nbsp;</th>
+                                                    <th class="NoVisible">&nbsp;</th>
                                                 [% END %]
                                                 <th>Card number</th>
                                                 <th>Surname</th>
@@ -179,7 +179,7 @@
                                                     [% IF ( op == 'show' ) %]
                                                         <td>
                                                     [% ELSE %]
-                                                        <td class="hidden">
+                                                        <td class="NoVisible">
                                                     [% END %]
                                                         <input type="checkbox" name="borrowernumber" value="[% borrower.borrowernumber | html %]" checked="checked" />
                                                     </td>
@@ -370,9 +370,6 @@
                 KohaTable("borrowerst", {
                     "order": [[ 1, "asc" ]],
                     "autoWidth": false,
-                    "columnDefs": [
-                        { "visible": false, "targets" : [ "hidden" ] }
-                    ]
                 }, table_settings);
 
                 $("#selectallbutton").click(function() {
-- 
2.39.5