]> git.koha-community.org Git - koha.git/commit
Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch
authorKenza Zaki <kenza.zaki@biblibre.com>
Tue, 23 Jul 2013 13:27:23 +0000 (15:27 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 13 Sep 2013 17:20:28 +0000 (14:20 -0300)
commit5ff99f63e32212071cc1e71749f93e943f005005
treef70bde537641a858164a622b5582947b6c1fa41c
parentafbc6e2e8a62ae2200e53ec61960e6297916dcc0
Bug 10629: remove inappropriate uses of $sth->finish() in C4::Branch

Test plan :
Check if the regression tests still works
prove t/db_dependent/Branch.t
t/db_dependent/Branch.t .. 1/36 Using a hash as a reference is deprecated at t/db_dependent/Branch.t line 207.
t/db_dependent/Branch.t .. ok
All tests successful.
Files=1, Tests=36,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.12 cusr  0.00 csys =  0.16 CPU)
Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
From the man page

finsh()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 4287fd9d1c3ae16a0496b6261de44642bc92ab9c)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Branch.pm