]> git.koha-community.org Git - koha.git/commit
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer
authorLiz Rea <liz@catalyst.net.nz>
Mon, 24 Nov 2014 23:03:50 +0000 (12:03 +1300)
committerChris Cormack <chrisc@catalyst.net.nz>
Wed, 3 Dec 2014 20:17:28 +0000 (09:17 +1300)
commitb28f439a582a5eafbdfb32b2890d6b069ec2df7c
tree269500bc2f11a6ba011dbc6d96de5fc2c06dba9a
parentb04c7ed1dd34100b649c1897f2ab3dc2cc1a6685
Bug 12123 - [Alternative patch] HTML notices can break the notice viewer

Depending on the content of an html notice, it can cause the notice to
either not be collapsible, be uncollapsible, or to be permanently
collapsed.

Test Plan:
1) Set your CHECKOUT notice to the following ( with HTML Message checked ) :
<p>The following items have been checked out:</p>

----
<blockquote> <<biblio.title>> </blockquote>
----

<p>Thank you for visiting the <<branches.branchname>> of HMCPL.</p>
2) Check out some items to a patron
3) View the patrn's notices
4) Note the notice viewer is broken ( message is not collapsed, and
   con't be collapsed ).
5) Apply this patch
6) Reload the page
7) Note the notice viewer is no longer broken

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
This patch appears to fix the problem with the minimum required change.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit ab2d2d2590fe4adf4adf6015f0ef441da8ad52a3)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt