]> git.koha-community.org Git - koha.git/commit
Bug 17990: Refactor Perl module versions check
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 25 Jan 2017 10:33:43 +0000 (11:33 +0100)
committerMason James <mtj@kohaaloha.com>
Sun, 29 Jan 2017 11:56:20 +0000 (00:56 +1300)
commitb4f9173a98535eefeabbd5c8c4435abaaa1ac2e1
tree94021df7942f47ff9bdbaf6c6342a4734cfc96cb
parent2367660e9dbc2052b2690a2c939d2a441863fbc0
Bug 17990: Refactor Perl module versions check

The code is duplicated, variable are not set ($_), code is hard to read,
not covered by tests and the subroutine has 2 completely different
behaviors depending on the presence of the "module" parameter.
No need more ti rewrite it.

Test plan:
- Use koha_perl_deps.pl with the different options (-u -m -a -i)
- Go on the about page, "Perl modules" tab

You should not see any differences from before and after this patch

Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Mason James <mtj@kohaaloha.com>
C4/Installer/PerlModules.pm
about.pl
installer/install.pl
koha_perl_deps.pl
t/Installer_PerlModules.t
t/Installer_pm.t