From b088664b1f6a2811ea52f4e2eb825786d4c0e2d8 Mon Sep 17 00:00:00 2001 From: Gaetan Boisson Date: Wed, 18 Dec 2013 15:19:50 +0100 Subject: [PATCH] Bug 11417: make sure remove_unused_authorities.pl accepts --test This patches adds support for the --test option, as well as a short message telling the user the script is running in test mode. Test plan : - Launch the script with -h to see the help - Launch the script with --test and --aut with an authtypecode that is used in your instance - Make sure it does the same thing as launching it with -t - Launch the script for real and make sure it still works as expected, deleting unused authorities. Signed-off-by: Galen Charlton Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton (cherry picked from commit 6657860010ef27792251596590c1471ad5d08ad8) Signed-off-by: Fridolin Somers (cherry picked from commit f6ab47d2e2039fde60670e7541f030d44dbc6bae) Signed-off-by: Tomas Cohen Arazi --- misc/migration_tools/remove_unused_authorities.pl | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/misc/migration_tools/remove_unused_authorities.pl b/misc/migration_tools/remove_unused_authorities.pl index fbeee78ad7..7920923ad8 100755 --- a/misc/migration_tools/remove_unused_authorities.pl +++ b/misc/migration_tools/remove_unused_authorities.pl @@ -27,12 +27,13 @@ use C4::Context; use C4::AuthoritiesMarc; use Getopt::Long; -my ($test,@authtypes); +my @authtypes; my $want_help = 0; +my $test = 0; GetOptions( - 'aut|authtypecode:s' => \@authtypes, - 't' => \$test, - 'h|help' => \$want_help + 'aut|authtypecode:s' => \@authtypes, + 't|test' => \$test, + 'h|help' => \$want_help ); if ($want_help) { @@ -40,6 +41,10 @@ if ($want_help) { exit 0; } +if ($test) { + print "testing only, authorities will not be deleted.\n"; +} + my $dbh=C4::Context->dbh; @authtypes or @authtypes = qw( NC ); my $thresholdmin=0; @@ -88,7 +93,7 @@ This script will parse all authoritiestypes given as parameter, and remove autho warning : there is no individual confirmation ! parameters --aut|authtypecode TYPE the list of authtypes to check - --t|test test mode, don't delete really, just count + --test or -t test mode, don't delete really, just count --help or -h show this message. _USAGE_ -- 2.39.5