]> git.koha-community.org Git - koha.git/commit
Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff
authorOwen Leonard <oleonard@myacpl.org>
Fri, 31 May 2013 16:05:49 +0000 (12:05 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Tue, 8 Oct 2013 14:07:31 +0000 (11:07 -0300)
commit3b9e88232d1296c1956c193820cf03d7e58edc63
tree0a555f21c932af936a892639d2dc3702e2070338
parent09b01f21276c309b4741abf31aafae9b2341c16f
Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff

The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC record or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
That's better - thx Owen!
Works nicely and passes all tests.
Tested in staff and OPAC, also in combination with NotesBlacklist
hiding all notes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit f5c7badb31dff9afcbb69e4f58155560e98a922f)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Works nicely.
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt