]> git.koha-community.org Git - koha.git/commit
Bug 10030: QA Followup for trivial false warning detected while testing
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 15 May 2013 14:06:49 +0000 (16:06 +0200)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Thu, 16 May 2013 01:52:05 +0000 (21:52 -0400)
commit4f881ba4846d29816cf7b5380a1ab3c0d27ca25d
tree15b861a67be8afd4fe3cbebd3abf1e8dfab66019
parentcdfe84068a10cd01a89a11a868056538782c2161
Bug 10030: QA Followup for trivial false warning detected while testing

Moving the warn line below the line that returns if amount<=0.
If amount<=0, a false warn is now raised because of the return after it.
We should only warn here if we do not return.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tested with fines.pl on overdue.
Before this patch:
Reducing fine for item 199709 borrower 23 from 44 to -1 - MaxFine reached.
This did not happen however because of the return.
After this change: no false warning.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(cherry picked from commit 656aba3e1ff1a2eb69baf9bbab38cf4b37b38afe)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
C4/Overdues.pm