]> git.koha-community.org Git - koha.git/commit
Bug 18736: (follow-up) Fix missing rounding and bad formatting
authorNick Clemens <nick@bywatersolutions.com>
Fri, 24 Aug 2018 01:22:35 +0000 (01:22 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 25 Mar 2019 14:29:29 +0000 (14:29 +0000)
commit5491709d806da011c8bcb4328417722932b39631
tree13759f9bc6fe75517fe52ff7ab91f25083aa38e6
parent277b869f18927c40041166ec5e825431a2a3f166
Bug 18736: (follow-up) Fix missing rounding and bad formatting

This patch:
Adds a missing use
Uses 'Koha::Number::Price->round()' instead of 'format()' to ensure numeric
returns
Ensures too big numbers don't crash round()
Uses syspref in 'GetBudgetHierarchy'

To test:
Follow previous test plan
Check values on admin/aqbudgets.pl are affected by syspref
Ensure values throughout acquisitions are correctly calculated/displayed
(even when greater than 1,000)

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 4ccbae8879a386a1846bb48c18b3722f936dc983)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Acquisition.pm
C4/Budgets.pm
Koha/Number/Price.pm
acqui/spent.pl