]> git.koha-community.org Git - koha.git/commit
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types
authorNick Clemens <nick@bywatersolutions.com>
Tue, 25 Aug 2020 10:35:02 +0000 (10:35 +0000)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 20 Oct 2020 01:32:24 +0000 (14:32 +1300)
commit8383009cc64698a4a0f28255702075e200ef2a98
tree7dbecda2e3b2a94e63a8b21ba50f36f18bddf1f6
parentc93f56c5baa6535c160ecb9adfad38a87a04f47a
Bug 18958: (follow-up) Ensure hold fill target reserve_id is set for all hold types

MapItemsToHoldRequests has three sections: Local holds, item level holds, bib level holds

Only one of them was setting the reserve_id. This patch makes al three set it and adds tests

To test:
1 - Repeat test plan on bug
2 - sudo koha-mysql kohadev
    SELECT * FROM hold_fill_targets
3 - Ensure reserve_id is set at appropriate times
4 - prove -v  t/db_dependent/HoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Bug 18958: (QA follow-up) Fix number of tests

In HoldsQueue.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b255ca7c6eec7be3027e6ade00d8477102062281)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit bac2e6892a817482f14249aceb1420c2700416d6)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
C4/HoldsQueue.pm
t/db_dependent/HoldsQueue.t