]> git.koha-community.org Git - koha.git/commit
Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 27 Aug 2021 14:56:08 +0000 (16:56 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 16 Sep 2021 07:47:39 +0000 (21:47 -1000)
commitb0c1bfc0ab83c5a602d7c24a421be3567eefd19b
tree4f6a1fe27949709ed9646aaef18c48e089dc6bc1
parent7ecc97c7085243627eb3ec1d839deafc9016f56c
Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set

If Pseudonymization is set but the bcrypt_settings config used by the
feature is not set, then there is an ugly 500 on checking out.

bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116.

However it's pretty hard to handle correctly this exception (and that's
why it hasn't be done initially). However we could prevent the pref to
be turned on if the config entry is not present.

Test plan:
Remove the bcrypt_settings from the config
Try to turn the syspref on
Add the config
Try to turn the syspref on/off

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
JD amended patch: fix qa failures

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit f73868b8ee121103e7406e26b20e9cf3ccae4eb7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
admin/preferences.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt