]> git.koha-community.org Git - koha.git/commit
Bug 21742: Fix YouTube variable propagation
authorNick Clemens <nick@bywatersolutions.com>
Wed, 31 Oct 2018 12:18:58 +0000 (12:18 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 26 Nov 2018 06:33:09 +0000 (07:33 +0100)
commitc18f11ff30288764181d2dc34a0d965516faa6c2
tree1966052ea61b02c45d50d47c23308d27ea7b6173
parent3ccb7d2da68315bf6eadd11df7536f3eb0b79779
Bug 21742: Fix YouTube variable propagation

The loop to find all media has an $isyoutube variable. This was declared
outside the loop and never reset. Once a YouTube video was encountered
all subsequent videos were considered as YouTube. This patch reduces the
scope of the variable and resets per loop.

To test:
1 - Enable HTML5Media and HTML5MediaYouTube
2 - Add 856$u to record for a youtube vido and a pdf (sample record
        attached to bug)
3 - View the record, the Play media tab has two video boxes
4 - Play the second, it fails
5 - Apply patch
6 - View record, Play media should include only one video link

Signed-off-by: Devinim <kohadevinim@devinim.com.tr>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 8ceba54c8dcfd9b598375b8af432c0111ec63d04)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit ec7e569d55575f26ba481684ff157c8ec3985002)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/HTML5Media.pm