]> git.koha-community.org Git - koha.git/commit
Bug 26190: Allow to close a basket with only cancelled order lines
authorKatrin Fischer <katrin.fischer.83@web.de>
Sat, 17 Oct 2020 22:47:49 +0000 (22:47 +0000)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 17 Nov 2020 05:29:44 +0000 (18:29 +1300)
commitf402c9366f2f1e192ac054aab34fa5e2cadde6d1
treea407ed27b49c8d35a4b47123a4f5a092d282b50f
parent81be2e66f63ce49730c822173ceddf857b0eb845
Bug 26190: Allow to close a basket with only cancelled order lines

At the moment there are several cases, when closing a basket is not
possible:
- when there are no order lines in it
- when there are order lines with uncertain prices
- when the basket is marked as a standing order

The first case wasn't checked correctly as only pending/received
orders would be counted, but not cancelled orders.

To test:
- Create a basket
- Create an order line
- Verify the "close this basket" button shows
- Cancel the order line - the button disappears
- Apply the patch
- Verify the button appears and works now
- Create another basket - make sure you cannot close it
  without order lines
- Create an order line with uncertain price checked
  - you cannot close it
- Resolve the uncertain price - you can now close the basket.

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 2d6595a1bf0e04611c2a1d5c18489c6ee799a9aa)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 87cbd07be836291f860ecbd5cea5538863317164)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
acqui/basket.pl