]> git.koha-community.org Git - koha.git/commit
Bug 14621: Messaging preferences table needs to be sorted
authorLari Taskula <larit@student.uef.fi>
Thu, 30 Jul 2015 15:34:49 +0000 (18:34 +0300)
committerMason James <mtj@kohaaloha.com>
Mon, 28 Sep 2015 12:14:33 +0000 (01:14 +1300)
commitf8472ef26cf352e5ee9df2420d78fa2dca3db074
tree8230a5c6ef3d5ff926dfc2fa59abca3edbb75488
parent499bb94087c67f0a9a123c9c756e847cc6818bfd
Bug 14621: Messaging preferences table needs to be sorted

I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu.

On messaging preferences page, the table is unsorted and the content in rows are generated randomly
on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes),
Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep
changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the
checkboxes are magically changing values on each page refresh.

Here is a patch that prevents this problem by sorting the messaging settings.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 46ac35f8e11c06a784ca309b0dc876aff9469edb)
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
(cherry picked from commit 6c44d1f4645b4c98577d6af23b05b9608b421253)
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
C4/Members/Messaging.pm