]> git.koha-community.org Git - koha.git/commit
Bug 19081: Do not list plugins that have been uninstalled
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 28 Aug 2017 17:00:28 +0000 (14:00 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 10 Oct 2017 08:35:49 +0000 (10:35 +0200)
commit53c84ea289e73fa2f56711dd8dd8e7ebac591ae7
tree4222aaa6ea37f267f679f44a25732b73b320fb12
parente175dda2cad4160b2a51d7d49370374b74c7d829
Bug 19081: Do not list plugins that have been uninstalled

Under plack, can_load should not check if a package is in cache, but
reload it. Otherwise plugins that have been uninstalled will still get
listed.
The error raised by can_load must only be displayed if the plugin has
been removed.

Test plan:
1/ Upload a plugin
2/ Note the plugin is listed as installed
3/ Modify the package of the plugin to add a compilation error (use
'Foo' for instance)
4/ Reload the page
5/ The plugin is not listed and a warning appear in the logs
6/ Remove the compilation error and uninstall the plugin
7/ The plugin is no longer listed and no warning appear in the logs

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Bug 19081: Remove useless $plugin_file variable

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d928038a523b7ef44257ddfe97c405173c9b3b2e)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Plugins.pm