From 14e82ee30d0bbd24870d9e62c63a2968d15c0493 Mon Sep 17 00:00:00 2001 From: Dobrica Pavlinusic Date: Wed, 20 Sep 2017 16:01:16 +0200 Subject: [PATCH] Bug 19350 - Holds without link in 773 trigger SQL::Abstract::puke Test: 1. find bibio without items which has something in field 773 (for us, it's article) but doesn't have 0 or 9 (host item entry) 2. click on hold in left menu 3. verify application error 4. apply patch and verify that it works Signed-off-by: Josef Moravec Signed-off-by: Mason James --- C4/Items.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/C4/Items.pm b/C4/Items.pm index 0f0465e2af..e2ddff81bd 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -1667,7 +1667,14 @@ sub get_hostitemnumbers_of { foreach my $hostfield ( $marcrecord->field($tag) ) { my $hostbiblionumber = $hostfield->subfield($biblio_s); + next unless $hostbiblionumber; # have tag, don't have $biblio_s subfield my $linkeditemnumber = $hostfield->subfield($item_s); + + if ( ! $linkeditemnumber ) { + warn "ERROR biblionumber $biblionumber has 773^0, but doesn't have 9"; + next; + } + my @itemnumbers; if (my $itemnumbers = get_itemnumbers_of($hostbiblionumber)->{$hostbiblionumber}) { -- 2.39.5