From fa73b3ef06f90694bfe16e6bf11a4eb6d3db5ebe Mon Sep 17 00:00:00 2001 From: Marcel de Rooy Date: Mon, 22 Nov 2021 07:55:47 +0000 Subject: [PATCH] Bug 29540: Raise flagsrequired in modrequest Test plan: Try modrequest with a user having only 'catalogue' perms and the following URLs: [1] /cgi-bin/koha/reserve/modrequest.pl?reserve_id=XX&CancelBorrowerNumber=XX&CancelItemnumber=XX&biblionumber=XX Fill the XXs with correct identifiers for some item level hold. [2] /cgi-bin/koha/reserve/modrequest_suspendall.pl?suspend=1&suspend_until=2021-12-01&borrowernumber=XX Fill the XX with borrowernumber for borrower that has pending holds. You should see: Error: You do not have permission to access this page. Signed-off-by: Marcel de Rooy [AMENDED] More consensus for using reserveforothers than circulate_remaining. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 15285ae209f5a98ab2e77c730b0b70ff0b29c283) Signed-off-by: Victor Grousset/tuxayo (cherry picked from commit 906228266b05fa660476d1f5b9320ac79241db82) Signed-off-by: Wainui Witika-Park --- reserve/modrequest.pl | 2 +- reserve/modrequest_suspendall.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/reserve/modrequest.pl b/reserve/modrequest.pl index 8872f4da94..bbb829c74e 100755 --- a/reserve/modrequest.pl +++ b/reserve/modrequest.pl @@ -35,7 +35,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( template_name => "about.tt", query => $query, type => "intranet", - flagsrequired => { catalogue => 1 }, + flagsrequired => { reserveforothers => 1 }, debug => 1, } ); diff --git a/reserve/modrequest_suspendall.pl b/reserve/modrequest_suspendall.pl index ea303f3083..5fca1f2a27 100755 --- a/reserve/modrequest_suspendall.pl +++ b/reserve/modrequest_suspendall.pl @@ -34,7 +34,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( template_name => "about.tt", query => $query, type => "intranet", - flagsrequired => { catalogue => 1 }, + flagsrequired => { reserveforothers => 1 }, debug => 1, } ); -- 2.39.5