]> git.koha-community.org Git - koha.git/commit
Bug 36575: Return correct patron when there is a shared userid / cardnumber
authorNick Clemens <nick@bywatersolutions.com>
Thu, 11 Apr 2024 09:39:03 +0000 (09:39 +0000)
committerFrédéric Demians <f.demians@tamil.fr>
Wed, 29 May 2024 07:14:11 +0000 (07:14 +0000)
commit99bfebe051cba3a66a12345692ad6bd098ba7e10
tree94088e629126cd9ca46998d03f7a626e7ecbf103
parent789bdc2a489ebdc8984299add2b9081965b75605
Bug 36575: Return correct patron when there is a shared userid / cardnumber

This patch moves some patron fetching code in C4/Auth to use to patron returned from the validation
methods and only try to fetch the patron (to check if locked, update attempts, etc) if we didn't authenticate

To test:
1 - Set a user to have userid = BANANA password = Password1
2 - Set a user to have cardnumber = BANANA password = Password2
3 - Hit the patron authentication API:
    http://localhost:8080/api/v1/auth/password/validation
    with data:
    { "identifier": "BANANA", "password":"Password1" }
    and:
    { "identifier": "BANANA", "password":"Password2" }
4 - Note you receive the same response for both
5 - Apply patch, restart all
6 - Repeat the API and confirm you get the correct patron for the password submitted

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
C4/Auth.pm
t/db_dependent/Auth.t
t/db_dependent/api/v1/password_validation.t