From 4c540598446082c191f6ba5f88316bdf3da0cd32 Mon Sep 17 00:00:00 2001 From: Joe Atzberger Date: Mon, 25 Aug 2008 22:57:01 -0500 Subject: [PATCH] Fines fixes: apparent problems with fines prevent processing. CalcFine returned values that mismatched expectations in fines.pl. fines.pl refactored: added debugging, prevent needless recreation of Calendar objects by storing them in hash by branch. Still outstanding problems with fines, including the output of a field that has no other references in Koha (so is always undef) and the incorrect description of FinesMode. Calendar exported "new" erroneously. I also cleaned up the queries to avoid needlessly compiling additional statement handles. Please test and consider application to 3.0 maintenance. Signed-off-by: Galen Charlton Signed-off-by: Chris Cormack --- misc/cronjobs/fines.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/cronjobs/fines.pl b/misc/cronjobs/fines.pl index de9e8cf7fb..0d0b97247e 100755 --- a/misc/cronjobs/fines.pl +++ b/misc/cronjobs/fines.pl @@ -90,7 +90,7 @@ for (my $i=0; $ioutput('iso'))); my $due_str = $datedue->output(); unless (defined $data->[$i]->{'borrowernumber'}) { - print STDERR "ERROR in Getoverdues line $i: issues.borrowernumber IS NULL. Repair 'issues' table now! Skipping record.\n"; + warn "ERROR in Getoverdues line $i: issues.borrowernumber IS NULL. Repair 'issues' table now! Skipping record.\n"; next; # Note: this doesn't solve everything. After NULL borrowernumber, multiple issues w/ real borrowernumbers can pile up. } my $borrower = BorType($data->[$i]->{'borrowernumber'}); -- 2.39.5