]> git.koha-community.org Git - koha.git/commit
Bug 38385: Improve DB update output on error (UI)
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 7 Nov 2024 10:33:03 +0000 (11:33 +0100)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Tue, 12 Nov 2024 16:50:17 +0000 (17:50 +0100)
commit0ab32306eee1572e259567f855a3a7fe8c4976e4
tree2632a983dc14cb92f94c8b1935cef3597c0ce416
parent2152ac1c66c3ebda401ed490f23970bcecf5ac0a
Bug 38385: Improve DB update output on error (UI)

When an error occurred during the DB update the UI is not correct.

1. say_success, say_info, etc. show the span tags and are not colored
2. "Everything went okay" shown even if atomic updates failed
3. The same error can be displayed several time (see https://snipboard.io/IGiKgM.jpg)

Test plan:
Create a new db rev and/or atomic update
Have some say_* statement to render messages, and raise an error

For instance:
    say_info( $out, "Use blue for further information" );

    try {
        say_warning( $out, "Use yellow for warning/a call to action" );
        $dbh->do(q{});
    } catch {
        say_failure( $out, "Use red for danger/failure" );
        $_->rethrow;
    };

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt