]> git.koha-community.org Git - koha.git/commit
Bug 36221: (follow-up) Style and markup fixes
authorOwen Leonard <oleonard@myacpl.org>
Mon, 11 Nov 2024 18:17:13 +0000 (18:17 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Tue, 12 Nov 2024 16:50:28 +0000 (17:50 +0100)
commit407fe2fa561d45e7cfff89e7b38c2ffd2f8e44ec
treeee0171a9c20961015a1879e1abbd6a4d839f6119
parent0205a5c5f1bb8e630a09e44e55f2d88813c803e5
Bug 36221: (follow-up) Style and markup fixes

This patch makes several changes to make the updated forms more
consistent with how other pages work:

- Form labels should have ":" after them.
- Form fields should have a hint when they are required.
  - Required fields should not be indicated with an asterisk.
- In the OPAC, <select> should have a "form-select" class if the form is
  otherwise being styled with Bootstrap classes.
- Primary submit buttons should have a "btn btn-primary" class.
- The Font Awesome 6 icon for a delete operation is "fa-trash-can."
- Error messages should be wrapped in <div class="alert alert-warning">.
- All language strings in JS files should be wrapped in __('').
- Terminology: "Library" instead of "Branch," "Patron" instead of
  "Member."

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Koha/ILL/Backend/intra-includes/create.inc
Koha/ILL/Backend/intra-includes/migrate.inc
Koha/ILL/Backend/opac-includes/create.inc
Koha/ILL/Backend/shared-includes/form_input_helpers.inc
Koha/ILL/Backend/shared-includes/shared.js