]> git.koha-community.org Git - koha.git/commit
Bug 36891: Restore returning 404 from svc/bib when the bib number doesn't exist
authorPhil Ringnalda <phil@chetcolibrary.org>
Fri, 17 May 2024 00:01:54 +0000 (17:01 -0700)
committerwainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
Tue, 17 Sep 2024 02:06:40 +0000 (02:06 +0000)
commit21523840625acf2c0f6dd85630da9561f016cd82
tree9c0d8c053d8d37c190bef11a11c7c3b401d1ef40
parent5ce0e962d742139110bf3c8b286ad07a70ec55d4
Bug 36891: Restore returning 404 from svc/bib when the bib number doesn't exist

Changing from GetMarcBiblio to Biblios->find plus metadata->record lost the
way that svc/bib used to return 404 when the bib number wasn't found. This
patch restores that by checking for undef after the Biblios->find step.

Test plan:
1. Load e.g. http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 which returns an
   XML bib record
2. Load http://127.0.0.1:8081/cgi-bin/koha/svc/bib/99999999 and get a 500 error
2. Appply patch, restart_all
4. Reload http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 and get the bib again
5. Reload http://127.0.0.1:8081/cgi-bin/koha/svc/bib/99999999 and get a 404

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: wainuiwitikapark <wainuiwitikapark@catalyst.net.nz>
svc/bib