]> git.koha-community.org Git - koha.git/commit
Bug 17900: Fix possible SQL injection in patron cards template editing
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 13 Jan 2017 16:43:25 +0000 (17:43 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 30 Jan 2017 11:19:55 +0000 (11:19 +0000)
commita70980d8255a66c33539926796c06b29b26fbb40
tree2461e91a3d57be5d45ed6aad05fef63493ee30fc
parent4ff78a9a0da486d7f267d1e252f3628ec1a5f149
Bug 17900: Fix possible SQL injection in patron cards template editing

To recreate:
/cgi-bin/koha/patroncards/edit-template.pl?op=edit&element_id=23%20and%201%3d2+union+all+select+1,user(),@@version+--%20

Look at the Profile dropdown list.

To fix this problem and to make sure it does not appears anywhere else
in the label and patroncards modules, I have refactored the way the
queries are built in C4::Creators::Lib
Now all of the subroutine takes a hashref in parameters with a 'fields'
and 'filters' parameters.
From these 2 parameters the new internal subroutine _build_query will
build the query and use placeholders.

Test plan:
1/ Make sure you do not recreate the vulnerability with this patch
applied.
2/ With decent data in the labels and patroncards modules, compare all
the different view (undef the New and Manage button groups) with and
without this patch applied.
=> You should not see any differences.

This vulnerability has been reported by MDSec.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Creators/Lib.pm
labels/label-edit-profile.pl
labels/label-edit-template.pl
labels/label-manage.pl
labels/label-print.pl
patroncards/edit-profile.pl
patroncards/edit-template.pl
patroncards/manage.pl
patroncards/print.pl
t/db_dependent/Creators/Lib.t