]> git.koha-community.org Git - koha.git/commit
Bug 26231: Remove incorrect use of AddAuthority() when 001 present
authorDavid Cook <dcook@prosentient.com.au>
Tue, 18 Aug 2020 02:20:32 +0000 (12:20 +1000)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 20 Oct 2020 01:06:43 +0000 (14:06 +1300)
commitbe9eeef3c9cc746e25a44b362d4d78a3739e4fb5
tree81601423c57ec2f19a6ecd50855cd31c8b45f4e9
parent20150ad3ebcfe26053f9bed0c28ebe331d4c15e0
Bug 26231: Remove incorrect use of AddAuthority() when 001 present

This patch removes the use of AddAuthority with a non-empty
authid argument, since that triggers an update rather than an insert.

In practice, the update also fails, but the error isn't raised,
as the database connection doesn't have RaiseError set.

Test plan:
1) Do not apply patch
2) Try to bulkmarcimport an authority file with a 001
3) Observe that the script reports success but no authority is added
4) Apply the path
5) Try to bulkmarcimport an authority file with a 001
6) Observe that the script reports success and the authority is added

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 9622561636387ced932cc31e285d13cdba607c47)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 276602aadbdb27cbec780c9564b93ccd0c1961b6)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
misc/migration_tools/bulkmarcimport.pl