]> git.koha-community.org Git - koha.git/commit
Bug 21172: Remove warning from addbiblio.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 7 Aug 2018 20:06:41 +0000 (17:06 -0300)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 10 May 2019 20:51:31 +0000 (20:51 +0000)
commit76fb88431031c9e86d88978663189f2af27ba1d7
treec5769784b17bcfb23054453638b6295618047753
parent9e4ac5634a09011b35e1cedc8f5e832a53e95263
Bug 21172: Remove warning from addbiblio.pl

Argument "01e" isn't numeric in numeric ne (!=) at
/home/vagrant/kohaclone/cataloguing/addbiblio.pl line 507.

A tagfield can be 01e and so raise a warning is compared with == or !=

This patch also fixes few inconsistencies:
- tagfield for items.itemnumber must be retrieved with GetMarcFromKohaField
(to support other marcflavours)
- do not use $_
- loop only once on $usedTagsLib

Test plan:
For devs only, read the code and confirm the changes make sense.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit f3afec0587f4baeff580e153ea592020d4d36be3)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 1ed01089db28deb6f9689bbb64c30ee805559dbf)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
cataloguing/addbiblio.pl