]> git.koha-community.org Git - koha.git/commit
Bug 6790: Remove unnecessary variable from getroutinglist return
authorColin Campbell <colin.campbell@ptfs-europe.com>
Fri, 26 Aug 2011 15:17:11 +0000 (16:17 +0100)
committerChris Nighswonger <chris.nighswonger@gmail.com>
Mon, 20 Feb 2012 02:33:45 +0000 (21:33 -0500)
commitf87892cfcfae2fb5d011d2cbf74b1fe5c40454d6
tree74eebe0ff94044f121deacdf409d84f703e3f30a
parent718e4f9bf486848396113143a7c283f98050a553
Bug 6790: Remove unnecessary variable from getroutinglist return

getroutinglist returns a count variable to indicate how many elements
are in the array. This is almost always a serious code smell. (We are
programming in a list manipulating language) The routine was executing
am unnecessary loop just to maintain that var.
Removed the variable from the routine and perldoc
refactored calls of the routine removed the c-style loops for
more idiomatic and maintainable for loops
renamed some opaquely named variables
removed a call to the routine where nothing was done with the data
moved some html out of the calling script and into the template

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
(cherry picked from commit d2c24f3bbff5c3ba96ce5ae8baa2313fabf786d5)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
(cherry picked from commit 5bed69ff231b9a9a3aca0128fd789c10cd47b1ba)

Signed-off-by: Chris Nighswonger <chris.nighswonger@gmail.com>
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
serials/routing-preview.pl
serials/routing.pl
serials/subscription-detail.pl