]> git.koha-community.org Git - koha.git/commit
Bug 10277: Add UT for C4::Context::IsSuperLibrarian
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 18 Dec 2013 15:12:00 +0000 (16:12 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 7 Aug 2014 07:37:20 +0000 (09:37 +0200)
commit618a119f0d737697a37b38cda0d5df7cc75ff7d2
treeef23d105ec35f3ea182ad1a3b2db0a66a01b7d5b
parentd003bfa37cc2dade07c5e18f2ef13ff27ce6aba8
Bug 10277: Add UT for C4::Context::IsSuperLibrarian

Note that I modify the return value. Before this patch, it returned an
empty string or 1. Now it returns 0 or 1.

Test plan:
- same as the original patch
- verify that unit tests pass:
    prove t/Context.t

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script, including new tests.
Checked the code and tested superlibrarian behaviour in some places:

moremember.pl:
With IndyBranches only superlibrarian can delete borrowers from
other branches. Accessing the borrower with a direct link.
OK

C4/Members.pm
With IndyBranches only superlibrarian can search for borrowres
from other branches.
OK

tools/holidays.pl
With IndyBranches only superlibrarian can edit holidays for other
branches.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 3e866d216db008e1ed8c8614f6758ad5118321df)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Context.pm
t/Context.t