]> git.koha-community.org Git - koha.git/commit
Bug 31421: Do not apply library limits to Categories plugin
authorNick Clemens <nick@bywatersolutions.com>
Thu, 6 Oct 2022 19:13:10 +0000 (19:13 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Mon, 14 Nov 2022 10:31:18 +0000 (11:31 +0100)
commit9cf7970159fb1f6fbd2f28226cd68a792948bac0
treeffb937ba84fd267d473b57790d90e162fb0d2dd8
parente46fc87a28c39886f3ab5bf5a359745e31e1d081
Bug 31421: Do not apply library limits to Categories plugin

This patch simply changes from using 'search_with_library_limits'
to 'search'

The limits I think are intended to prevent users from setting a patron to the wrong category,
they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search
but cannot be processed. The dropdowns as well won't contain the category, so you can see these
patrons, but not filter by the category

Bug 31422 and bug 31032 point out further issues with limits.

For now, let's fix searching

To test:
1 - Edit Patron category 'Patron/PT'
2 - Try to do a patron search that returns patrons in this category
3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined
4 - Apply patch
5 - Restart all and repeate
6 - It works now!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 29754226ea3b6bdaf896e5b8d19f44b1ed551e11)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit fbde769aec127ab899a52197d9c0b176c54b87c4)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Koha/Template/Plugin/Categories.pm