]> git.koha-community.org Git - koha.git/commit
Bug 21417: EDI ordering fails when basket and EAN libraries do not match
authorKyle M Hall <kyle@bywatersolutiosn.com>
Thu, 27 Sep 2018 10:51:27 +0000 (06:51 -0400)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 8 Nov 2018 15:28:05 +0000 (16:28 +0100)
commitc8efbde5ed6bb62e4c4d81872e0f7eebdbe9d4cd
tree3e46aa71f3b6058cfd4110dcec5671777441cfd5
parent68c83c4c8691307c65025717003417f870cb1098
Bug 21417: EDI ordering fails when basket and EAN libraries do not match

When clicking Create EDIFACT Order on /acqui/basket.pl, an EDIFACT message will not be generated if aqbasket.branch does not match edifact_ean.branchcode. This failure does not generate any sort of error message, it just fails to produce a message.

We should allow ean's to not require a branch to be set, then if we don't find a branch specific each, we can look for the default version of the ean.

Test Plan:
1) Apply this patch set
2) Run updatedatabase
3) Verify you can create a Library EAN without setting a branchcode for it
4) Verify you can use this EAN to send an EDI order where the basket has a branchcode set

Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com>
Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 18674cfde322c52fafb3114b397bb1ebe7941b97)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit c2537558e0ed79cc00a71d7405b7e738835372a8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/EDI.pm
admin/edi_ean_accounts.pl
installer/data/mysql/atomicupdate/bug_21417.perl [new file with mode: 0644]
installer/data/mysql/kohastructure.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/edi_ean_accounts.tt