]> git.koha-community.org Git - koha.git/commit
Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Tue, 10 Jan 2017 09:03:36 +0000 (10:03 +0100)
committerMason James <mtj@kohaaloha.com>
Sun, 30 Apr 2017 11:19:55 +0000 (23:19 +1200)
commitf083c8a0672490ea55dcd9b2e7b57d78115c0113
tree0dac33bcd9613c722458cd8cfd26298c506e4571
parenteaf914f591947adf9c56c30ee018713adba91bab
Bug 17872: Fix small error in GetBudgetHierarchy and one of its calls

In aqbudgetperiods.pl a commented line is removed that contains a
wrong userenv hash key. Should be branch instead of branchcode.

In aqbudgets GetBudgetHierarchy is called with the same wrong userenv
hash key. Should be userenv->{branch}.
This made another bug visible: if you call GetBudgetHierarchy with a
branch and without owner, the where clause should take into account
that the branchcode can be empty (not null).

Test plan:
[1] Run Budgets.t
[2] Run aqbudgets.pl from Administration
[3] Add the show_mine=1 parameter in the URL
[4] Change owner of one of the funds and repeat step 2 and 3.

t/Budgets.t returns green. Followed test plan, works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Mason James <mtj@kohaaloha.com>
C4/Budgets.pm
admin/aqbudgetperiods.pl
admin/aqbudgets.pl