]> git.koha-community.org Git - koha.git/commit
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t
authorMark Tompsett <mtompset@hotmail.com>
Wed, 6 Jul 2016 18:17:20 +0000 (14:17 -0400)
committerFrédéric Demians <f.demians@tamil.fr>
Fri, 5 Aug 2016 07:01:39 +0000 (09:01 +0200)
commitad5acf73bc03f2a68ebbaa27c3d9399ce38551ae
treeae17d8dd103dba0cefca687d8ff9f42d4d02b701
parent241c64434855980b46b1dd9f347c9b2e45adf2e4
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t

prove t/db_dependent/ILSDI_Services.t
generates noisy output as a result of the ambiguous context
of two $cgi->param() calls.

By storing into scalar variables, and then using the scalar
variables, the code maintains readability and fixes the problem.

TEST PLAN
---------
1) prove t/db_dependent/ILSDI_Services.t
   -- noisy.
2) apply patch
3) prove t/db_dependent/ILSDI_Services.t
   -- not noisy
4) run koha qa test tools

Signed-off-by: Marc <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
(cherry picked from commit ef0738922005e4235b80e70663d7fa711a87556e)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
C4/ILSDI/Services.pm