From 316bcd396227638058d4fa6c7c409bc45ebf8c8c Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 22 May 2024 10:08:30 +0200
Subject: [PATCH] Bug 36816: Remove warning

Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629.

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
(cherry picked from commit 98637f17a7e59b2fbf0d8d9331b2508065211913)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 opac/opac-memberentry.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl
index 355ac8f487..38ac55d945 100755
--- a/opac/opac-memberentry.pl
+++ b/opac/opac-memberentry.pl
@@ -630,11 +630,11 @@ sub FilterUnchangedAttributes {
 
     # Loop through the current patron attributes
     foreach my $attribute_type ( keys %{ $patron_attribute_types } ) {
-        if ( $patron_attribute_types->{ $attribute_type } !=  $passed_attribute_types->{ $attribute_type } ) {
+        if ( ( $patron_attribute_types->{$attribute_type} // q{} ) ne ( $passed_attribute_types->{$attribute_type} // q{} ) ) {
             # count differs, overwrite all attributes for given type
-            foreach my $attr (@{ $entered_attributes }) {
+            foreach my $attr ( @{$entered_attributes} ) {
                 push @changed_attributes, $attr
-                    if $attr->{ code } eq $attribute_type;
+                    if $attr->{code} eq $attribute_type;
             }
         } else {
             # count matches, check values
-- 
2.39.5