From aa8c26ae520667b17286dbac0f63a2583fb1b9e3 Mon Sep 17 00:00:00 2001
From: David Cook <dcook@prosentient.com.au>
Date: Mon, 24 Jul 2023 06:17:13 +0000
Subject: [PATCH] Bug 25672: Prevent uninstall when plugin browser upload
 disabled

When plugin browser upload is disabled, also prevent plugin browser
uninstall.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../intranet-tmpl/prog/en/modules/plugins/plugins-home.tt    | 2 ++
 plugins/plugins-uninstall.pl                                 | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
index aefd39d1e2..a703437b6e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt
@@ -220,7 +220,9 @@
                                                             [% END %]
                                                         [% END %]
                                                         [% IF ( CAN_user_plugins_manage ) %]
+                                                            [% IF ( enable_browser_upload ) %]
                                                                 <li><a class="uninstall_plugin" data-plugin-name="[% plugin.metadata.name | html %]" href="/cgi-bin/koha/plugins/plugins-uninstall.pl?class=[% plugin.class | html %]"><i class="fa fa-trash-can fa-fw"></i> Uninstall</a></li>
+                                                            [% END %]
                                                             [% IF ( plugin.is_enabled ) %]
                                                                     <li><a class="enable_plugin" data-plugin-name="[% plugin.metadata.name | html %]" href="/cgi-bin/koha/plugins/plugins-enable.pl?class=[% plugin.class | html %]&method=disable"><i class="fa fa-pause fa-fw"></i> Disable</a></li>
                                                             [% ELSE %]
diff --git a/plugins/plugins-uninstall.pl b/plugins/plugins-uninstall.pl
index d6a85d39d3..50ee3490c3 100755
--- a/plugins/plugins-uninstall.pl
+++ b/plugins/plugins-uninstall.pl
@@ -38,8 +38,11 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
     }
 );
 
+my $browser_upload_enabled = C4::Context->config('enable_plugin_browser_upload');
 my $class = $input->param('class');
 
-Koha::Plugins::Handler->delete( { class => $class } );
+if ( $browser_upload_enabled && $class ) {
+    Koha::Plugins::Handler->delete( { class => $class } );
+}
 
 print $input->redirect("/cgi-bin/koha/plugins/plugins-home.pl");
-- 
2.39.5