]> git.koha-community.org Git - koha.git/commit
Bug 18854 - Protect from DOS
authorChris Cormack <chris@bigballofwax.co.nz>
Sun, 25 Jun 2017 05:34:12 +0000 (17:34 +1200)
committerMason James <mtj@kohaaloha.com>
Sun, 30 Jul 2017 13:02:09 +0000 (01:02 +1200)
commit1c254e0d298b6139771dd05e1d71aa2a9d75cd5c
tree6c00997dfe51f6ff95d34553e1182851d653b0ec
parent296f18f3302c63617fc9280b978cda3d8cda9c4f
Bug 18854 - Protect from DOS

There was a bug that meant a very large offset in the search params
will cause the search script to run forever (or long enough to crash
the machine)

To test

1/ Get ready with sudo top so you can kill the thread before it causes
your machine to OOM
2/ Hit a page like yourdomain.com/cgi-bin/koha/opac-search.pl?q=1&offset=-9999999999999999999
3/ Notice the process runs for a long time
4/ Kill the process
5/ Apply the patch
6/ Hit the page again, notice the it loads (offset is set to zero)
7/ Do the same to search in the staff client

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Amended: changed -2 to 0 in opac-search.pl.
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Mason James <mtj@kohaaloha.com>
catalogue/search.pl
opac/opac-search.pl