]> git.koha-community.org Git - koha.git/commit
Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 18 Jun 2020 13:01:36 +0000 (09:01 -0400)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sun, 26 Jul 2020 15:07:06 +0000 (17:07 +0200)
commit4e2a8c53c3d59d5927e2f668680ba565252341c0
tree185e448731736ab349bd59cfc871f5d45926f96c
parentd363f0246809e1906b3af50f7c6a35abbb1e710c
Bug 25805: Return empty strings instead of undef in C4::SIP::ILS::Item::hold_patron_name

This bug is basically the same as bug 24966, but for hold_patron_name instead of hold_patron_bcode.
The subroutine hold_patron_bcode should always return an empty string, not undef.

Test Plan:
1) Using the SIP cli emulator, checkin an item that is not checked out
2) Note the DA field contains someting like "C4::SIP::SIPServer=HASH(0x88175c8)"
   The hex number will almost certainly be different from this example
3) Apply this patch
4) Restart the SIP server
5) Run the SIP checkin again
6) Note the DA field is no longer present!

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 017b67e6c52ab7b79a0187b1ca9fea220117f7ef)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 18faf9b7aa7c313fd9fa086c5f9609ef7b0c70f5)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
(cherry picked from commit f22bded52404114572988e445e1ca0398fa3227d)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/SIP/ILS/Item.pm