]> git.koha-community.org Git - koha.git/commit
Bug 16886: Make the 'Upload patron images' tool plack safe
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sat, 9 Jul 2016 12:13:35 +0000 (13:13 +0100)
committerJulian Maurice <julian.maurice@biblibre.com>
Fri, 16 Sep 2016 06:55:44 +0000 (08:55 +0200)
commit8af766cc52057f73c025918fb359acf33901da52
tree85454141d0f1acb6c6fd7fe1667c49f83daa4157
parentade420fb05bfe70638e4e87951423f5efe591776
Bug 16886: Make the 'Upload patron images' tool plack safe

Some vars are accessed from subroutine, but defined with my.
It causes at least the 2 followings errors:
Variable "$filetype" is not available at
/home/koha/src/tools/picture-upload.pl line 240.
Variable "$uploadfilename" is not available at
/home/koha/src/tools/picture-upload.pl line 241.

To avoid that, they are now declared with our.

Test plan:
Upload image for a patron and confirm that you get a "Result" table and
the errors do not longer appear in the logs.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 762415a2ff18e5a1b783f8eff2275e7d47216343)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
(cherry picked from commit 4cf4751c08edb6830714cc6dd3408ccb089756cd)
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
tools/picture-upload.pl